CRM-21159: Address fields cause DB errors when adding contacts to group from Search Builder

[ajesamson]

Overview

Fixes for problem with Address fields causing DB errors when adding contacts to group from Search Builder.

Before

The "DB Error: no such field" screen appears directly after clicking or selecting "Group - add contacts." when the Search Builder is used to create a search that includes an address field ( State and Country)

After

The page now loads properly with all required fields resolved.

Technical Details

Join statement was missing in the generated query. Only reference to the table alias was added to the where clause.

---

• CRM-21159: Address fields cause DB errors when adding contacts to group from Search Builder

[civicrm-builder]

Can one of the admins verify this patch?

[seamuslee001]

Jenkins test this please

[eileenmcnaughton]

This is a good fix that stalled due to lack of a unit test. However, I have just managed to replicate the bug in a unit test so I will submit that as a follow up to this.

The patch is limited in scope to 2 fields - state_province_id & country_id in the scenario where there might be multiple joins on the address table since search builder allows the selection of location type. I was concerned that it might be adding an unnecessary join but the address table is being joined in but not the country table (not required as the name has been resolved to an ID).

Merging