CRM-21512 Remove restriction on 'Update Subscription' when a recurring contribu…

[mattwire]

…tion has a linked membership

Overview

Currently the "Update Subscription" (ie. Edit Recurring Contribution) is not allowed when the recurring contribution is linked to a membership.
This is inconsistent with the "Change Billing Details" option which is allowed at all times and is unclear as to why it is not allowed (as it works fine with a supported payment processor).

Before

Error message when you click "Edit" on a recurring contribution from the contact summary - "You cannot update the subscription".

After

You can update the subscription. A warning is shown on the "Update Subscription" form to show that it is linked to a membership:

Comments

This is a (non-breaking) change in behaviour so should be flagged clearly in the release notes.

[JoeMurray]

I would like this to be thoroughly tested with a variety of payment processors plugins and extensions. I worry some may not support edits to recurring contributions as a change to the current recurring contribution, but instead end the current one and start a new one. This may have untoward effects on relationship between recurring donation and membership.

To be clear: this is just a worry that I would like more thoroughly tested.

[eileenmcnaughton]

I don't think this is a worry from a payment processor point of view- most are very simple & @KarinG has said she doesn't use recurring with memberships for IATS.

In terms of extensions - this only arises if extension writers are doing something convoluted with a fairly obscure configuration. I can't think of any obvious high-use extensions to test. I think perhaps this should be advertised to the dev list for comment & bare any specific concerns then having a clear annotation in the release notes seems fine.

In terms of risk/concern - this makes a change to rare / obscure behaviour, allowing an existing screen to permit something a bit odd, but apparently sometimes desirable. That seems lower risk than some other changes I can think of.

[KarinG]

To clarify: iATS Extension can process recurring contributions related to memberships [it's on my test matrix/grid]; Personally: I never use recurring contributions tied to membership - with any payment processor [instead I always use recurring contributions that through jobs later on to create a membership ad-hoc];

[eileenmcnaughton]

I'm going to merge this - it's pretty edge case that it would be used & I feel the main people involved in writing processors have indicated an awareness of this PR without registering any specific issues with it. The warning is enough to mitigate the fact that changing a recurring linked to a membership does not have clear expectations IMHO