CRM-21511 Add recurring contribution link to membership and contribution detail #11365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monishdeb Do you have 5 minutes to review this one? |
monishdeb
reviewed
Jan 16, 2018
CRM/Member/Form/MembershipView.php
Outdated
| // Add recurring contribution | ||
| if (!empty($values['contribution_recur_id'])) { | ||
| $this->assign('recurContribution', $values['contribution_recur_id']); | ||
| } |
There was a problem hiding this comment.
@mattwire I think you don't need to assign it to separate smarty variable, as below at L406 the $values array assigned to smarty. So in templates/CRM/Member/Form/MembershipView.tpl
+ {if $contribution_recur_id}
+ <tr>
+ <td class="label">{ts}Recurring Contribution{/ts}</td>
+ <td>
+ <a class="crm-hover-button" href='{crmURL p="civicrm/contact/view/contributionrecur" q="reset=1&id=`$recurContribution`&cid=`$contactId`&context=contribution"}'>View Recurring Contribution</a>
+ </td>
+ </tr>
+ {/if}should work. What do you think?
mattwire
force-pushed
the
CRM-21511_recur_on_membership_detail
branch
from
ba512ec to
4627f70
Compare
|
@monishdeb Thanks, I've made the changes as you suggested and that works. |
|
Code looks good to me. It's a minimal change and @monishdeb also reiewed, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow-on from CRM-21504. Add link to recurring contribution from membership detail and contribution detail.
Before
Not easy to see/access recurring contribution from membership detail/contribution detail.
After
(Note: screenshots are from a shoreditch theme so do not look perfect!)
Added "Recurring Contribution" line:
"Recurring contribution" is now a link:
