Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21469: Fix removal from all groups from Edit Contact #11311

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Nov 22, 2017

Overview

Caused by CRM-15830: when editing a contact record, it is not possible to remove all groups.

How to reproduce:

  • Create a contact, add the contact to 1 group
  • Edit the contact, remove the group from the list of groups for that contact (NB: not from the 'Group' tab, that works fine).

Result: the contact is still in the group.

When testing, also test that this works correctly even if "Groups and Tags" is disabled from the Contact Preferences (Admin > Customize screens > Display Preferences).


@mlutfy
Copy link
Member Author

mlutfy commented Nov 22, 2017

nb: I could not figure out why groups and tags are handled differently in this form. Tags have the same problem, but I could not find a quick fix.

@eileenmcnaughton
Copy link
Contributor

(CiviCRM Review Template WORD-1.0)

I took a quick look at the code and am happy to merge once it has been UI tested

@eileenmcnaughton
Copy link
Contributor

I UI tested it & agree this fixes it for groups (but no tags) with no apparent downside

@eileenmcnaughton eileenmcnaughton merged commit 237a3ff into civicrm:master Nov 30, 2017
@eileenmcnaughton eileenmcnaughton deleted the crm21469 branch November 30, 2017 07:29
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
CRM-21469: Fix removal from all groups from Edit Contact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants