(NFC) .toxic.json - Update list of functions which yield toxic warnings #11302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file `.toxic.json` is supposed to list egregious functions -- any change to these functions should produce extra comments/suggestsions. The current list is a few years old, so I've run `pdepend` and updated the list. The list includes anything which matches one or more of these: * "Non Comment Lines of Code" (`ncloc`) greater than 300. * "[NPath](https://modess.io/npath-complexity-cyclomatic-complexity-explained/) complexity" (`npath`) greater than 1 billion.
|
let's give it a spin |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
(NFC) .toxic.json - Update list of functions which yield toxic warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The file
.toxic.jsonis supposed to list egregious functions -- any changeto these functions should produce extra comments/suggestsions.
The current list is a few years old, so I've run
pdependand updated the list.Before
The list was generated a few years ago.
After
The list includes anything which matches one or more of these:
ncloc) greater than 300.npath) greater than 1 billion.