NFC code tidy up preparatory to CRM-19273 #11272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of reducing https://github.com/civicrm/civicrm-core/pull/10962/files easier to parse this makes some small code tidy ups 1) renames functions to not use the deprecated convention of leading underscore 2) renames function to getLineItemsToAlter rather than 'to add & update' (later changes will cause this array to include 'to_cancel' & 'to_resurrect') 3) changes the array return format for that function to be an array of requiredChanges 4) rename function _getFinancialItemsToRecord to getReverseFinancialItemsToRecord to reflect the fact it is generating an array of reversals to perform
|
Tested the patch, working fine. |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
NFC code tidy up preparatory to CRM-19273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code cleanup to remove the Non functional changes from #10962 to facilitate code review.
Before
Code is less pretty
After
Code is more pretty (marginally). Code changes in #10962 can be reduced
Technical Details
As part of reducing https://github.com/civicrm/civicrm-core/pull/10962/files easier to parse this makes some small
code tidy ups
(later changes will cause this array to include 'to_cancel' & 'to_resurrect')
reflect the fact it is generating an array of reversals to perform