Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21421 - Api case update should not re-save case contacts #11270

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 11, 2017

Overview

Case api was generating an error when trying to re-save the case contacts in a case with the same values. This prevents it from doing so, as the caseContact api is intended for such operations.

@mlutfy
Copy link
Member

mlutfy commented Nov 15, 2017

@mattwire Since you were the original reporter of this issue, can you test & confirm?

@mattwire
Copy link
Contributor

@mlutfy @colemanw This looks good. I've updated my PR to be a unit test for CaseContact.create instead of the original patch - can you look at that too please once this is merged? (As test will fail without this PR).

@colemanw colemanw merged commit a393337 into civicrm:master Nov 15, 2017
@colemanw colemanw deleted the CRM-21421 branch November 16, 2017 02:23
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
CRM-21421 - Api case update should not re-save case contacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants