Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21416: Add reset link beside 'Search' button below Advance Search form #11260

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Nov 9, 2017

Overview

Add 'Reset Form' link beside 'Search' button below Advance Search form

Before

screen shot 2017-11-09 at 1 38 48 pm

After

screen shot 2017-11-09 at 1 37 31 pm


@mattwire
Copy link
Contributor

mattwire commented Nov 9, 2017

@monishdeb Have tested this and it works fine. It's a trivial template change that will have no impact elsewhere. It would be nice to implement this on some of the other search forms too, but that shouldn't block this PR.
@eileenmcnaughton @colemanw ready to merge?

@colemanw
Copy link
Member

colemanw commented Nov 9, 2017

I'm confused about one thing @monishdeb - why is the markup set to both float left and float right?

@monishdeb
Copy link
Member Author

monishdeb commented Nov 10, 2017

@colemanw thanks for pointing that out. Earlier I have added float left to place the link next to Search button, but didn't knw that crm_right class was the reason to align the link at right. I have removed both the style and class and updated the PR. Tested on different theme, works for me:
Bartik -
screen shot 2017-11-10 at 12 16 16 pm

Seven -
screen shot 2017-11-10 at 12 15 41 pm

@colemanw colemanw merged commit 0f6fa7a into civicrm:master Nov 10, 2017
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
CRM-21416: Add reset link beside 'Search' button below Advance Search form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants