Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP CRM-21256 Improve performance of payment processor load #11060

Closed
wants to merge 2 commits into from
Closed

WIP CRM-21256 Improve performance of payment processor load #11060

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dab9698
Don't load and validate test processors when we only need live
mattwire Oct 3, 2017
38cd4fb
Use static variable so we only check once per request in hasPaymentPr…
mattwire Oct 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions CRM/Financial/BAO/PaymentProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ public static function getPaymentProcessors($capabilities = array(), $ids = FALS
$processors = self::getAllPaymentProcessors('all', TRUE, FALSE);
}
else {
$processors = self::getAllPaymentProcessors('all', TRUE);
$processors = self::getAllPaymentProcessors('live', TRUE, TRUE);
}

if (in_array('TestMode', $capabilities) && is_array($ids)) {
Expand Down Expand Up @@ -444,8 +444,13 @@ public static function getPaymentProcessors($capabilities = array(), $ids = FALS
* @return bool
*/
public static function hasPaymentProcessorSupporting($capabilities = array()) {
$result = self::getPaymentProcessors($capabilities);
return (!empty($result)) ? TRUE : FALSE;
static $results;
$capabilitiesString = implode('', $capabilities);
if (!isset($results[$capabilitiesString])) {
$result = self::getPaymentProcessors($capabilities);
$results[$capabilitiesString] = (!empty($result)) ? TRUE : FALSE;
}
return $results[$capabilitiesString];
}

/**
Expand Down