CRM-20769 Rebuild multilingual structure based on DAOs after adding c… #11051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doing a local upgrade test of the multilingual upgrade test suggests the view correctly gets rebuilt now |
|
This seems like a required fix to avoid a regression and it is just an extra call to an existing function so it should be something we can rely on. I suspect it should be moved to 'addColumn'. Merging now to avoid release chaos but would dearly love some more testing per comments above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…olumns to table
Overview
Following report from @litespeedmarc it seems the multilingual views aren't probably being re-generated after adding the new columns. This triggers a multilingual rebuild without caring if we are in upgrade mode so builds of the DAOs
@litespeedmarc are you able to test this on your install also pinging @mlutfy @eileenmcnaughton