CRM-21121 - Fix crash with sql_mode is only_full_group_by

[MegaphoneJon]

Overview

The Event Income Summary report crashes if your sql_mode is only_full_group_by (which is default on MySQL 5.7.5+)

Before

Crash (see JIRA for backtrace)

After

No crash.

Technical Details

I was concerned about simply grouping by the currency - but then I saw that events don't support multiple currencies (though this report DOES support multiple currencies, just not on the same event).

If that were to change in the future, this SQL statement would need to change anyway, so I believe this is safe.

Comments

A tester should ideally have MySQL 5.7.5+ (Ubuntu 16.04+ has it). Testing is relatively simple, because the SQL generated is pretty straightforward.

---

• CRM-21121: Event Income (Summary) report backtrace with 'only_full_group_by'

[eileenmcnaughton]

@lcdservices might be one for you to check?

[lcdservices]

Confirmed -- this fixes the MySQL group by error. @eileenmcnaughton can you merge?

[eileenmcnaughton]

Thanks for putting this up / reviewing it.

[JKingsnorth]

This caused a regression in CRM-20170, and I've raised an issue about it here: https://issues.civicrm.org/jira/browse/CRM-21417

[monishdeb]

@JKingsnorth I have prepared an alternate patch https://gist.github.com/monishdeb/2383e6e9c88b83d3fa96d07f03c97547 which will fix the regression and will take care of CRM-21121. Can you please test my patch?

[monishdeb]

After discussion with @seamuslee001 on dev-channel, I realised that my earlier patch will cause issue with MariaDB as it won't support ANY_VALUE so here's my second patch https://gist.github.com/monishdeb/2e8c399510765da4539d9866dda88df1 which I believe will fulfill all criteria.