CRM-21110 Do not run same/similar query twice when generating Relatio…

[seamuslee001]

…nships Tab in CiviCRM

Overview

Previously two queries would be run every time when listing active and inactive relationships for a contact in the Relationships tab. The 2nd query was only to a total number of relationships which seemed very expensive

Before

Two very similar queries were run

After

1 round of queries are run and are more performent now

Comments

@eileenmcnaughton i would appreciate your thoughts on this, i think this is sane but would like your feedback on this

[eileenmcnaughton]

You need to make it DROP TEMPORARY TABLE - could be causing the test fails as it will block rollback without the keyword

[eileenmcnaughton]

@seamuslee001 it makes sense but for performance issues that is a poor indicator of whether it is a good fix :-)

Did you do any tests to check how long the queries take?

[monishdeb]

As per the fix the result is now stored in civicrm_contact_relationships temp table that is used for getting both relationship count and records. Tested in my local and it's working fine.
However, it will affect performance if there are over 1k records. But in this case I won't think it will cross that mark as this function is used to fetch relationships on provided contact ID basis.

So, for me the PR is ok to merge 👍

[eileenmcnaughton]

Ok - I can accept that if this is limited by contact_id the performance should be acceptable - merging based on @monishdeb QA