CRM-21077 Add warning when CIVICRM_MAIL_LOG is set and you are testing outbound… #10870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seamuslee001
approved these changes
Aug 18, 2017
|
@seamuslee001 What does "looks good" mean? Does that mean you tried it out and found that the PR works as expected -- or does it mean that (upon skimming) the code seems like a plausible rendition of the concept? |
|
It means to be upon skimming the code it looks sensible, strings make sense to me but i haven't yet tested it |
|
I have now tested this on a buildkit install and it works as expected |
|
Brilliant. :) Thank you, @seamuslee001 @mattwire. |
|
makes sense. I think there is a status check that covers this too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… mail settings
Overview
When the environment variable CIVICRM_MAIL_LOG is set CiviCRM won't try to send mail via any of the methods, but it will return success indicating that it did send mail. Normally that's fine, except when you forget you've got that configured (or didn't realise - buildkit does it by default). With this patch, when testing outbound email settings you will get a warning message if CIVICRM_MAIL_LOG is set so you don't scratch your head for ages wondering why email is not being sent out!