Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NFC) Improve docs in CONTRIBUTING.md #10853

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

seancolsen
Copy link
Contributor

Overview

Before

  • CONTRIBUTING.md contained some useful information which was not in (or discoverable from) the Developer Guide
  • Other useful content from the Developer Guide was not discoverable from CONTRIBUTING.md

After

  • Content generally related to contributing is more consolidated within the Developer Guide
  • CONTRIBUTING.md makes that content easily discoverable

This ia a non-functional
change. In civicrm/civicrm-dev-docs#275
I migrated some of the content from CONTRIBUTING.md into the
Developer Guide. This commit removes that content from
CONTRIBUTING.md and puts hyerlinks in its place.
@seancolsen
Copy link
Contributor Author

seancolsen commented Aug 18, 2017

Prerequisite changes were merged into the Dev Guide in civicrm/civicrm-dev-docs#273 (instead of civicrm/civicrm-dev-docs#275 as originally planned).

According to me, this PR can now be merged into core (but it still needs a review).

@eileenmcnaughton
Copy link
Contributor

Makes sense to me!

@eileenmcnaughton eileenmcnaughton merged commit c39c74b into civicrm:master Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants