CRM-21031 Fix for id instead of financialtype name

[mattwire]

---

• CRM-21031: Financial type ID display instead of label in "View Price Options"

[eileenmcnaughton]

Seems sensible & safe as it only affects a browse page @seamuslee001 - does this tie in at all with your work on disabled financial types & do you have any comment?

[seamuslee001]

So this will have the issue of as far as i can tell returning blank value i.e. NULL if the Financial Type that is used by a price option is disabled (I believe that is the default of CRM_Utils_Array::value). This is because https://github.com/civicrm/civicrm-core/blob/master/CRM/Contribute/PseudoConstant.php#L110. Now in this case that might make sense given that the FT isn't really active and therefore shouldn't we be showing a difference.

[seamuslee001]

I would also add that this is an improvement as i can't see how $financialType is getting set at all in the browse() function

[eileenmcnaughton]

Ok @seamuslee001 that seems like this is good to merge then. I think you could make a pretty good argument for blank for a disabled type (& an even better one for showing it highlighted in red with a strike through, but I won't hold out for that)

[mattwire]

@seamuslee001 @eileenmcnaughton I actually wanted to use CRM_Core_PseudoConstant::getKey but couldn't work out what params I needed for financial_type_id.

[eileenmcnaughton]

CRM_Core_PseudoConstant::getKey('CRM_Contribution_BAO_Contribution', 'financial_type_id', $value)

[eileenmcnaughton]

(ie. financial_type_id is a field on the contribution BAO/DAO

[mattwire]

@eileenmcnaughton So that's what I actually thought it should be, but that doesn't return a value:
$type = CRM_Core_PseudoConstant::getKey('CRM_Contribute_BAO_Contribution', 'financial_type_id', 1); // Expected result: "Donation"'; Actual result: "false"

This works: $financialTypes = CRM_Contribute_BAO_Contribution::buildOptions('financial_type_id', 'get');

[eileenmcnaughton]

Hmm - OK so I got that wrong, there are 3 functions
CRM_Core_PseudoConstant::getKey
CRM_Core_PseudoConstant::getName
CRM_Core_PseudoConstant::getLabel

so, depending on whether you wanted the unique name or the label one of the latter 2 should work