CRM-21005, "Record Payment" dialogue lacks required field and is clunky #10817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-21005: "Record Payment" dialogue lacks required field and is clunky https://issues.civicrm.org/jira/browse/CRM-21005
---------------------------------------- * CRM-21005: "Record Payment" dialogue lacks required field and is clunky https://issues.civicrm.org/jira/browse/CRM-21005
monishdeb
requested changes
Aug 4, 2017
| @@ -100,7 +100,7 @@ | |||
| </td> | |||
| </tr> | |||
| <tr class="crm-payment-form-block-payment_instrument_id"> | |||
| <td class="label">{$form.payment_instrument_id.label}</td> | |||
| <td class="label">{$form.payment_instrument_id.label} <span class="crm-marker" title="{ts}This field is required.{/ts}">*</span></td> | |||
There was a problem hiding this comment.
@pradpnayak why can't we change at backend by setting required parameter TRUE for payment_instrument_id here ?
There was a problem hiding this comment.
Because the same form is used to pay as a credit card using payment processor, in those case this field should not be required.
|
tested and confirmed. |
monishdeb
reviewed
Aug 7, 2017
| @@ -252,7 +255,7 @@ public function buildQuickForm() { | |||
| $this->add('select', 'payment_instrument_id', | |||
| ts('Payment Method'), | |||
| array('' => ts('- select -')) + CRM_Contribute_PseudoConstant::paymentInstrument(), | |||
| FALSE, | |||
| TRUE, | |||
There was a problem hiding this comment.
@pradpnayak I have set required = TRUE because this field is present only in backoffice form not on live mode, see the check is made on line 252 above. Also tested in my local and it's working fine w/o live mode.
|
My bad :(, Tested works fine. |
monishdeb
approved these changes
Aug 7, 2017
|
@colemanw can you please test and merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR holds fix
Before
After
)