CRM-21019, Changed column labels on batch transaction listing page #10813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-21019: Change column labels https://issues.civicrm.org/jira/browse/CRM-21019 changed labels fixed labels
|
tested and confirmed. these labels better identify the purpose of each column. |
|
@eileenmcnaughton / @colemanw can you please review? |
|
Yes that's a lot more clear. One suggestion: "Expected Batch Total" and "Actual Batch Total" instead of "Batch Total Amount" and "Actual Batch Total Amount" |
|
+1 on Coleman's suggestion. |
|
Actually I think the word "batch" is redundant. We know it's a batch already. For those four columns in the 1st screenshot I propose: | Expected Number of Items | Actual Number of Items | Expected Total Amount | Actual Total Amount | |
|
+1 to latest suggestion from Coleman #10813 (comment) |
|
@colemanw I have updated the PR. Thanks for your feedback. |
|
tested and confirmed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-21019
Overview
This PR fixes the column labels on batch transaction listing page
Before
After