Unit test for CRM-20970

[eileenmcnaughton]

• CRM-20970: long postal code in db prevents searching by zipcode range

[eileenmcnaughton]

This is a unit test to go with #10769 change

note that I identified a further issue - searching for postal_code < 50 will include NULL values.. If someone wants to QA & review that I will follow up with a patch - the change is

  $field = "IF (civicrm_address.postal_code REGEXP '^[0-9]{1,10}$', CAST(civicrm_address.postal_code AS UNSIGNED), 0)";

should be

  $field = "IF (civicrm_address.postal_code REGEXP '^[0-9]{1,10}$', CAST(civicrm_address.postal_code AS UNSIGNED), NULL)";

[mfb]

to reproduce bug we have to hit CRM_Contact_BAO_GroupContactCache::load()

so maybe also need a test in tests/phpunit/CRM/Contact/BAO/GroupContactCacheTest.php?

[eileenmcnaughton]

@mfb I'll help you if you wanna write one! However, I don't think the bug is replicable on my mysql version at all as I was testing by running the query directly

[mfb]

I'll work on a test when I can.. Here's a minimal query that should fail on any MySQL with STRICT_TRANS_TABLES (it's on by default in MySQL 5.7):

CREATE TEMPORARY TABLE foo (SELECT CAST('12345678444455555555555555555555555555555555551314151617181920' AS UNSIGNED) AS bar);
ERROR 1292 (22007): Truncated incorrect INTEGER value: '12345678444455555555555555555555555555555555551314151617181920'

[mfb]

👍 ok this is actually ready to be merged, my bad. I verified that the existing test does in fact create a smartgroup and therefore reproduces the Exception (test output is "F"; if you comment out the failing assertion then we hit the following lines which report "E"). Dev environment = Ubuntu 17.04 with MySQL 5.7 where STRICT_TRANS_TABLES is on by default.

[monishdeb]

Nice 👍