Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20979 - expose pre help for price fields to the UI #10780

Merged
merged 2 commits into from
Aug 29, 2017

Conversation

jitendrapurohit
Copy link
Contributor

@jitendrapurohit jitendrapurohit commented Jul 28, 2017

Price Field form has Field Help which act as a post help text. We have a column to store pre_help in civicrm_price_field, but no field in UI to accept and insert the value in the table.


@jitendrapurohit jitendrapurohit changed the title CRM-20979 - pre help for price fields not exposed to UI wip - CRM-20979 - pre help for price fields not exposed to UI Aug 6, 2017
@jitendrapurohit
Copy link
Contributor Author

tagging as wip as this needs discussion of how/where the pre-help text should be shown. I'll update this soon.

@jitendrapurohit jitendrapurohit changed the title wip - CRM-20979 - pre help for price fields not exposed to UI CRM-20979 - pre help for price fields not exposed to UI Aug 7, 2017
@jitendrapurohit
Copy link
Contributor Author

Fixed the display - it is shown as -

image

@eileenmcnaughton
Copy link
Contributor

This looks safe & sensible to me & the screenshot looks to be clear. Merging

@eileenmcnaughton eileenmcnaughton changed the title CRM-20979 - pre help for price fields not exposed to UI CRM-20979 - expose pre help for price fields to the UI Aug 29, 2017
@eileenmcnaughton eileenmcnaughton merged commit 56e0a9b into civicrm:master Aug 29, 2017
@jitendrapurohit jitendrapurohit deleted the CRM-20979 branch August 29, 2017 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants