CRM-20966: Do not create membership_payment record for inherited membership (when two memberships created in back end via price set).

[davejenx]

Please note: this PR fixes a problem that occurs in the specific scenario described at CRM-20966: Contribution deleted when relationship deleted, incorrect line items & membership_payments for second inherited membership created in back end via price set.
In 4.7, in order to replicate this problem you will need to have applied the fix for CRM-20955 = #10745 . Otherwise the second membership won't inherit and so the incorrect line_item and membership_payment records will not occur. See issue description at CRM-20966.

---

• CRM-20966: Contribution deleted when relationship deleted, incorrect line items & membership_payments for second inherited membership created in back end via price set
• CRM-20955: Contact's second membership fails to inherit when created in back end using price set

[lcdservices]

Tested and confirmed this is working. No membership_payment record was created for the inherited member -- only for the member owner.

[davejenx]

@lcdservices Thanks for testing! Presumably in order to test this on 4.7, you first applied #10745 - did that work OK, could you add a comment on that PR? Thanks again.

[davejenx]

There's a 4.6 version of this patch: #10760 .

[lcdservices]

No, I didn't actually -- I just applied this patch and verified that the membership_payment record was only created to attach the membership owner's record to the contrib. It looks like that other PR has to do with a scenario where a contact has multiple memberships? And the additional memberships weren't getting inherited properly?

[davejenx]

@lcdservices Apologies, seems my description wasn't clear enough. I was relying on the fact that the details of the problem scenario are in the JIRA issue CRM-20966 but I should have also made that clearer in the PR description. I've now added this to the description:

"Please note: this PR fixes a problem that occurs in the specific scenario described at CRM-20966: Contribution deleted when relationship deleted, incorrect line items & membership_payments for second inherited membership created in back end via price set."

So this PR too is specific to a scenario where a contact has multiple memberships, created in back end via price set, using the steps to reproduce described in CRM-20966.

Really appreciate you testing and I'm sorry that the original description wasn't clear enough.

[lcdservices]

I retested having applied this and PR-10745 -- everything is working as intended.

[davejenx]

@lcdservices That's great, thank you. I'm sorry that this was a confusing one to test.