CRM-20964: Include queue id while retrieving rows from Event Queue

[jitendrapurohit]

CRM_Mailing_Event_BAO_Queue::getRows(); return rows for each intended recipients, but doesn't include any info which differentiates each row.

This adds a queue_id in the key column of the $result array which enables hooks to know which row is getting displayed.

It seems safe to add key here as getRows() is only called at this point which doesn't use the key info for manipulation.

---

• CRM-20964: Include queue id while retrieving rows from Event Queue.

[jitendrapurohit]

test this please

[lcdservices]

Should the ID be added as an array element too? That would make it clear to developers what the ID is, whereas only using it for the array key is less apparent.

[jitendrapurohit]

Thanks for the response @lcdservices. I'll check and update if it doesn't break any stuffs.

[jitendrapurohit]

@lcdservices Sorry for the delay.

Attaching queue id to the array element would result in addition of another column in the display page. Note the id 1 after the date column in the below screenshot -

Reason why I included this as a key rather than column, as from the code it seems the key is not being used for any manipulation by civi. And the hooks eg module_civicrm_searchColumns() can easily make use of this queue_id without affecting any core functionality.

[lcdservices]

Ok. I didn't realize the array was used in its entirety for the table construction. Using the ID as the array key is fine and a useful improvement. @monishdeb can you merge this.

[monishdeb]

Done

[jitendrapurohit]

Thanks @lcdservices @monishdeb