Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-19186 / CRM-20959 Subsequent Installments of Recurring Credit Card Contributions Indicate a Payment Instrument of Check #10749

Merged
merged 2 commits into from
Aug 21, 2017
Merged

CRM-19186 / CRM-20959 Subsequent Installments of Recurring Credit Card Contributions Indicate a Payment Instrument of Check #10749

merged 2 commits into from
Aug 21, 2017

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 25, 2017 •
edited by xurizaemon
Loading

@eileenmcnaughton
Copy link
Contributor Author

@xurizaemon this fixes the problem & moves to a better tested / more recommended copy path - but it would need thorough review. I think I'll set to WIP until you have prod tested it.

@eileenmcnaughton eileenmcnaughton changed the title Add test for payment_instrument_id [WIP] Add test for payment_instrument_id Jul 25, 2017
@eileenmcnaughton
Copy link
Contributor Author

also needs a jira

@xurizaemon
Copy link
Member

JIRA created (then marked dupe). Further steps for this issue will include possibly an upgrader step that cleans up the borked data. See CRM-19186.

@eileenmcnaughton
Copy link
Contributor Author

eileenmcnaughton commented Jul 27, 2017 •
edited
Loading

Oh right - I actually wrote a patch as well as a test - I guess I'll remove WIP & wait for you to confirm how it goes in production. Note that I think it's better to give any date clean up script it's own PR so we can close this against the issue it is closed in

@eileenmcnaughton eileenmcnaughton changed the title [WIP] Add test for payment_instrument_id CRM-19186 / CRM-20959 Subsequent Installments of Recurring Credit Card Contributions Indicate a Payment Instrument of Check Jul 27, 2017
@monishdeb
Copy link
Member

monishdeb commented Aug 9, 2017 •
edited
Loading

Patch works fine. Only stuff remaining, like @xurizaemon said will be to write upgrade code to fix the oddities in financial_trxn. Are we expecting a separate PR for that?

@eileenmcnaughton
Copy link
Contributor Author

@monishdeb I don't think we should hold this PR on the upgrade code

@monishdeb
Copy link
Member

This patch fixes the bug described in the issue. Merging it now

@monishdeb monishdeb merged commit d663c2b into civicrm:master Aug 21, 2017
@monishdeb
Copy link
Member

@eileenmcnaughton in exchange can you review and merge this PR #10681 ?

@eileenmcnaughton eileenmcnaughton deleted the ipn branch August 22, 2017 02:39
twomice added a commit to Jmanage/com.pogstone.paymentprocessorhelper that referenced this pull request Oct 19, 2017
@twomice
Updating overridden CiviCRM core file with changes in CRM-19186.
484de06 
References:
https://pogstone.zendesk.com/agent/tickets/14306
https://issues.civicrm.org/jira/browse/CRM-19186
civicrm/civicrm-core#10749
commit 5d07dffc50a4d98d20cd7f82e68afce407d9dfd6 in remote ssh://[email protected]/jvillage-civicrm47.git
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eileenmcnaughton @xurizaemon @monishdeb @civicrm-builder