CRM-20901, Added submit credit card membership link #10689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-20901: Add submit credit card membership link on membership form https://issues.civicrm.org/jira/browse/CRM-20901
pradpnayak
changed the title
|
@jitendrapurohit can you test this - looks fine / safe to me |
|
@eileenmcnaughton @colemanw can you please merge this PR as approved by Jitendra? |
|
Makes sense |
eileenmcnaughton
changed the title
|
@monishdeb @pradpnayak @JoeMurray can we only use the negative [WIP] in the titles - if there is no WIP then a PR should be ready for review by any reviewer who steps up. It's pretty ugly to have the [ready for core team review] in our it history & the fact it's ready for review should be implicit (unless {WIP} is in the title |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-20901