Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-20747: {contribution.campaign} token not working on Contribution #10575

Merged
merged 1 commit into from
Jul 1, 2017
Merged

CRM-20747: {contribution.campaign} token not working on Contribution #10575

merged 1 commit into from
Jul 1, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Jun 28, 2017 •
edited by civicrm-builder
Loading

@monishdeb
Copy link
Member Author

@colemanw @totten I think this PR need to be merged in 4.7.21 as it fixes this regression. As earlier contribution.getsingle API was introduced to fetch contribution token values (including custom fields), but unfortunately, this causes regression for campaign token due to different index as contribution_campaign_title. Ensured that all other contribution tokens are working.

I have included only the fix, as the unit test is covered in #10533 for master.

seamuslee001
seamuslee001 approved these changes Jun 28, 2017
View reviewed changes
Copy link
Contributor

@seamuslee001 seamuslee001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@monishdeb
Copy link
Member Author

Merging as per @seamuslee001 review, also the changes fix a regression reported on dev-post-release after 4.7.20 release.

@monishdeb monishdeb merged commit 63d18d0 into civicrm:4.7.21-rc Jul 1, 2017
@monishdeb monishdeb deleted the CRM-20747-rc branch July 1, 2017 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seamuslee001 seamuslee001 seamuslee001 approved these changes

Assignees
No one assigned
Labels
4.7.21-rc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monishdeb @seamuslee001 @civicrm-builder