API allows creating multiple addresses same location type #10510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @johntwyman |
|
Just noticed the comment
Wouldn't it be better to fix this at BAO level instead of duplicating validation at form and api level? |
|
Yes, quite possibly! I'm not quite sure whether we should still permit it for 3 though - since we historically have it seems wrong to change it now. Perhaps the BAO can support both but default to 'replace' for v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @eileenmcnaughton this test passes but is an issue i think, the API is allowing >= 2 addresses of the same location type yet the form layer would block this just thinking should we be limiting the API as per form layer?