Fix CRM-20488: remove restrictions on soft credit contact type. #10419
Conversation
|
Removing "WIP" prefix now that all checks have passed. @jitendrapurohit and @monishdeb, this is related (indirectly at least) to work by you in CRM-18102 and CRM-13981. Are you able to comment or review? |
twomice
changed the title
| // which will be used to constraint soft-credit contact type in formRule, CRM-13981 | ||
| if (!empty($profileId[0]) && !empty($profileId[2])) { | ||
| $form->_honoreeProfileType = CRM_Core_BAO_UFGroup::getContactType($profileId[0]); | ||
| } |
There was a problem hiding this comment.
If you remove this part, I think we don't have any purpose to have preProcess() here as it seems this function was only used to set _honoreeProfileType in $form. Can we remove preProcess() from this file then ?
There was a problem hiding this comment.
Yes, good point. Done.
There was a problem hiding this comment.
Further,
-
I think we should also remove any reference to this preProcess() to avoid any fatal errors caused by this change - one I can see is here.
-
Remove definition of
_honoreeProfileTypeas it doesn't seem to be used elsewhere.jitendra$ grep -irn honoreeProfileType CRM CRM/Contribute/Form/Contribution.php:157: public $_honoreeProfileType;
There was a problem hiding this comment.
Sure, I should have thought of that. Will get you something soon. Thanks!
monishdeb
force-pushed
the
CRM-20488_soft_credit_organization
branch
from
621a529 to
8cf9d8b
Compare
There was a problem hiding this comment.
@twomice @jitendrapurohit I have made a minor fix i.e. removed the SC::preProcess(...) call from codebase. And tested the patch, it works fine
|
@monishdeb worth removing unused var highlighted in point 2 of previous comment ? |
|
Oops, submitted a PR #10532 for that. Thanks |
|
works great! |
I'm going with the notion that the correct solution here is just to remove the limitation on contact type for soft credits.