Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20615 Export only those batches whose status is exported #10394

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

pradpnayak
Copy link
Contributor


----------------------------------------
* CRM-20615: Export only those batches having status Exported
  https://issues.civicrm.org/jira/browse/CRM-20615
Copy link
Member

@monishdeb monishdeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working fine.

@colemanw / @eileenmcnaughton can you please review and merge this PR? Thanks!

@eileenmcnaughton
Copy link
Contributor

@monishdeb the code looks fine & I agree it does what is described.

I'm not sure I understand enough to judge if what is described is a correct change & just constitutes a bug fix - @lcdservices or @agileware might be able to confirm for me? Or Guy I - who I can't ping from github I don't think

@lcdservices
Copy link
Contributor

Tested and confirmed. Created a batch and added transactions to it. While in Open status, selected Export action. The file was exported and the batch was correctly changed to the Export status. This was addressing a mismatch between the batch status (Exported) and the generation/download of the export file.

@colemanw colemanw merged commit 4568166 into civicrm:master Aug 9, 2017
@JoeMurray
Copy link
Contributor

So from my perspective, we should change the status to exported after, not before, the export is done. Things fail, especially potentially long running tasks and file downloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants