Add test to check pcp notification is sent

I wound up adding PcpBlock v4 api to write the test In support of #19096
civicrm · Dec 5, 2020 · f6992e7 · f6992e7
1 parent da508f6
commit f6992e7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/Civi/Api4/PcpBlock.php → Civi/Api4/PCPBlock.php b/Civi/Api4/PcpBlock.php → Civi/Api4/PCPBlock.php
@@ -23,6 +23,6 @@
  *
  * @package Civi\Api4
  */
-class PcpBlock extends Generic\DAOEntity {
+class PCPBlock extends Generic\DAOEntity {
 
 }
diff --git a/api/v3/utils.php b/api/v3/utils.php
@@ -334,9 +334,7 @@ function _civicrm_api3_get_DAO($name) {
   if ($name === 'Im' || $name === 'Acl' || $name === 'Pcp') {
     $name = strtoupper($name);
   }
-  if ($name === 'PcpBlock') {
-    $name = 'PCPBlock';
-  }
+
   $dao = CRM_Core_DAO_AllCoreTables::getFullName($name);
   if ($dao || !$name) {
     return $dao;

diff --git a/tests/phpunit/CRMTraits/PCP/PCPTestTrait.php b/tests/phpunit/CRMTraits/PCP/PCPTestTrait.php
@@ -10,6 +10,7 @@
  */
 
 use Civi\Api4\Email;
+use Civi\Api4\PCPBlock;
 
 /**
  * Trait CRMTraits_PCP_PCPTestTrait
@@ -86,7 +87,7 @@ public function pcpParams() {
   protected function createPCPBlock(array $params):int {
     $blockParams = $this->pcpBlockParams();
     $params = array_merge($this->pcpParams(), $params);
-    $params['pcp_block_id']  = \Civi\Api4\PcpBlock::create()->setValues($blockParams)->execute()->first()['id'];
+    $params['pcp_block_id']  = PCPBlock::create()->setValues($blockParams)->execute()->first()['id'];
 
     $pcp = CRM_PCP_BAO_PCP::create($params);
     return (int) $pcp->id;