REF/tests - Simplify inline conditionals with Elvis

civicrm · Aug 24, 2023 · d717e4f · d717e4f
1 parent d894dd5
commit d717e4f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tests/phpunit/CiviTest/CiviUnitTestCase.php b/tests/phpunit/CiviTest/CiviUnitTestCase.php
@@ -1430,7 +1430,7 @@ public function CustomGroupMultipleCreateWithFields($params = []) {
   public function entityCustomGroupWithSingleFieldCreate($function, $filename): array {
     $params = ['title' => $function];
     $entity = substr(basename($filename), 0, strlen(basename($filename)) - 8);
-    $params['extends'] = $entity ? $entity : 'Contact';
+    $params['extends'] = $entity ?: 'Contact';
     $customGroup = $this->customGroupCreate($params);
     $customField = $this->customFieldCreate(['custom_group_id' => $customGroup['id'], 'label' => $function]);
     CRM_Core_PseudoConstant::flush();
@@ -1453,7 +1453,7 @@ public function entityCustomGroupWithSingleFieldCreate($function, $filename): ar
   public function entityCustomGroupWithSingleStringMultiSelectFieldCreate($function, $filename) {
     $params = ['title' => $function];
     $entity = substr(basename($filename), 0, strlen(basename($filename)) - 8);
-    $params['extends'] = $entity ? $entity : 'Contact';
+    $params['extends'] = $entity ?: 'Contact';
     $customGroup = $this->customGroupCreate($params);
     $customField = $this->customFieldCreate(['custom_group_id' => $customGroup['id'], 'label' => $function, 'html_type' => 'Multi-Select', 'default_value' => 1]);
     CRM_Core_PseudoConstant::flush();