Fix APIv4 test to assert an exception is thrown

The test had only run its assertion in the catch block which would have been skipped if an exception wasn't thrown
civicrm · Nov 21, 2020 · d34aa01 · d34aa01
1 parent b316694
commit d34aa01
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/tests/phpunit/api/v4/Action/ContactGetTest.php b/tests/phpunit/api/v4/Action/ContactGetTest.php
@@ -88,12 +88,14 @@ public function testGetWithLimit() {
     $limit2 = Contact::get(FALSE)->setLimit(2)->addSelect('sort_name', 'row_count')->execute();
     $this->assertCount(2, (array) $limit2);
     $this->assertCount($num, $limit2);
+    $msg = '';
     try {
       $limit2->single();
     }
     catch (\API_Exception $e) {
-      $this->assertRegExp(';Expected to find one Contact record;', $e->getMessage());
+      $msg = $e->getMessage();
     }
+    $this->assertRegExp(';Expected to find one Contact record;', $msg);
     $limit1 = Contact::get(FALSE)->setLimit(1)->execute();
     $this->assertCount(1, (array) $limit1);
     $this->assertCount(1, $limit1);