Skip to content

Commit

Permalink
Remove a couple of non-test tests
Browse files Browse the repository at this point in the history
  • Loading branch information
eileenmcnaughton committed Jun 7, 2022
1 parent 90998dc commit cd8b113
Showing 1 changed file with 0 additions and 34 deletions.
34 changes: 0 additions & 34 deletions tests/phpunit/api/v3/SyntaxConformanceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1261,22 +1261,6 @@ public function testNotImplemented_create($Entity) {
$this->assertStringContainsString(strtolower("API ($Entity, Create) does not exist"), strtolower($result['error_message']));
}

/**
* @dataProvider entities
* @param $Entity
*/
public function testWithoutParam_create($Entity) {
$this->expectException(CiviCRM_API3_Exception::class);
if ($Entity === 'Setting') {
$this->markTestSkipped('It seems OK for setting to skip here as it silently sips invalid params');
}
elseif ($Entity === 'Mailing') {
$this->markTestSkipped('It seems OK for "Mailing" to skip here because you can create empty drafts');
}
// should create php complaining that a param is missing
civicrm_api3($Entity, 'Create');
}

/**
* @dataProvider entities_create
*
Expand Down Expand Up @@ -1319,24 +1303,6 @@ public function testValidSortSingleArrayById_get($Entity) {
}
}

/**
* @dataProvider entities_create
*
* Check that create doesn't work with an invalid
* @param $Entity
* @throws \PHPUnit\Framework\IncompleteTestError
*/
public function testInvalidID_create($Entity) {
// turn test off for noew
$this->markTestIncomplete("Entity [ $Entity ] cannot be mocked - no known DAO");
return;
if (in_array($Entity, $this->toBeImplemented['create'])) {
// $this->markTestIncomplete("civicrm_api3_{$Entity}_create to be implemented");
return;
}
$result = $this->callAPIFailure($Entity, 'Create', ['id' => 999]);
}

/**
* @dataProvider entities_updatesingle
*
Expand Down

0 comments on commit cd8b113

Please sign in to comment.