Fix membership/issues#16 Duplicate lineitems when creating a recurrin…

…g membership via backend
civicrm · Sep 20, 2019 · c80e665 · c80e665
1 parent e7e4788
commit c80e665
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/CRM/Member/BAO/Membership.php b/CRM/Member/BAO/Membership.php
@@ -376,7 +376,7 @@ public static function create(&$params, &$ids = []) {
 
     // This could happen if there is no contribution or we are in one of many
     // weird and wonderful flows. This is scary code. Keep adding tests.
-    if (!empty($params['line_item']) && empty($ids['contribution'])) {
+    if (!empty($params['line_item']) && empty($ids['contribution']) && empty($params['contribution_id'])) {
 
       foreach ($params['line_item'] as $priceSetId => $lineItems) {
         foreach ($lineItems as $lineIndex => $lineItem) {