Don't force boolean fields to be NOT NULL

civicrm · Apr 16, 2024 · b63ecd3 · b63ecd3
1 parent 59aed5d
commit b63ecd3
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/mixin/lib/civimix-schema/src/SqlGenerator.php b/mixin/lib/civimix-schema/src/SqlGenerator.php
@@ -91,7 +91,8 @@ private function generateCreateTableSql(array $entity): string {
         $fieldSql .= " COLLATE {$field['collate']}";
       }
       // Required fields and booleans cannot be null
-      if (!empty($field['required']) || $field['sql_type'] === 'boolean') {
+      // FIXME: For legacy support this doesn't force boolean fields to be NOT NULL... but it really should.
+      if (!empty($field['required'])) {
         $fieldSql .= ' NOT NULL';
       }
       if (!empty($field['auto_increment'])) {