Merge pull request #23599 from aydun/contriberror

Make this error message more informative.
civicrm · May 27, 2022 · b070641 · b070641
2 parents ba02783 + 8d57846
commit b070641
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CRM/Batch/BAO/EntityBatch.php b/CRM/Batch/BAO/EntityBatch.php
@@ -45,7 +45,7 @@ public static function create($params) {
         ->execute()
         ->first();
       if ($batchCurrency && $batchCurrency !== $trxn['currency']) {
-        throw new \CRM_Core_Exception(ts('You can not add items of two different currencies to a single contribution batch.'));
+        throw new \CRM_Core_Exception(ts('You cannot add items of two different currencies to a single contribution batch. Batch id %1 currency: %2. Entity id %3 currency: %4.', [1 => $batchId, 2 => $batchCurrency, 3 => $entityId, 4 => $trxn['currency']]));
       }
       if ($batchPID && $trxn && $batchPID !== $trxn['payment_instrument_id']) {
         $paymentInstrument = CRM_Core_PseudoConstant::getLabel('CRM_Batch_BAO_Batch', 'payment_instrument_id', $batchPID);

diff --git a/tests/phpunit/api/v3/EntityBatchTest.php b/tests/phpunit/api/v3/EntityBatchTest.php
@@ -113,7 +113,7 @@ public function testMultipleCurrencies(): void {
       'entity_table' => 'civicrm_financial_trxn',
     ];
     $result = $this->callAPIFailure($this->_entity, 'create', $secondEntityBatchParams);
-    $this->assertEquals('You can not add items of two different currencies to a single contribution batch.', $result['error_message']);
+    $this->assertEquals("You cannot add items of two different currencies to a single contribution batch. Batch id {$batchId} currency: USD. Entity id {$secondFinancialTrxnId} currency: CAD.", $result['error_message']);
   }
 
 }