Deprecate guess work in processPriceSet

Testing to see how much of this we can deprecate - line items should be 'complete' before reaching the processing function
civicrm · Jun 28, 2021 · 4ec7a83 · 4ec7a83
1 parent 175c023
commit 4ec7a83
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/CRM/Price/BAO/LineItem.php b/CRM/Price/BAO/LineItem.php
@@ -391,6 +391,9 @@ public static function processPriceSet($entityId, $lineItems, $contributionDetai
           $line['entity_id'] = $entityId;
         }
         if (!empty($line['membership_type_id'])) {
+          if (($line['entity_table'] ?? '') !== 'civicrm_membership') {
+            CRM_Core_Error::deprecatedWarning('entity table should be already set');
+          }
           $line['entity_table'] = 'civicrm_membership';
         }
         if (!empty($contributionDetails->id)) {