Merge pull request #20843 from demeritcowboy/smartyreptable

Smarty notices - Missing type on logging civireport
civicrm · Jul 14, 2021 · 0caf521 · 0caf521
2 parents a515643 + 3f9312f
commit 0caf521
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CRM/Logging/ReportDetail.php b/CRM/Logging/ReportDetail.php
@@ -103,9 +103,9 @@ public function __construct() {
     }
 
     $this->_columnHeaders = [
-      'field' => ['title' => ts('Field')],
-      'from' => ['title' => ts('Changed From')],
-      'to' => ['title' => ts('Changed To')],
+      'field' => ['title' => ts('Field'), 'type' => CRM_Utils_Type::T_STRING],
+      'from' => ['title' => ts('Changed From'), 'type' => CRM_Utils_Type::T_STRING],
+      'to' => ['title' => ts('Changed To'), 'type' => CRM_Utils_Type::T_STRING],
     ];
   }
 

diff --git a/templates/CRM/Logging/ReportDetail.tpl b/templates/CRM/Logging/ReportDetail.tpl
@@ -9,6 +9,7 @@
 *}
 <div class="crm-block crm-content-block crm-report-form-block">
   {if $rows}
+    {* todo: Is `raw` ever assigned to the template and why would it make a difference as to whether this div is present? The revert confirmation is handled (awkwardly) lower down by javascript $revertConfirm *}
     {if $raw}
       <div class="status">
         <dl>