Create basepage for E2E tests #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it and it worked, however we may be better to wait for @christianwach to try a refactoring of the plugin activation |
|
We're criss-crossing threads a bit, but in the other thread Kevin followed-up and suggested merging anyway. Refactoring is good, but it seems unlikely to get into 5.23. Since @seamuslee001 says this was working for him, I'm gonna merge. Whenever we do have updates to the install mechanism, then we can remove/replace the two itemized tasks from #509 and #510. Hopefully that'll be circa 5.24 or 5.25? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the basepage is not created until the UI loads. This loads it via wp-cli.