Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default layout for CiviCRM admin and ability to configure/set to default. Issue #15 #20

Merged
merged 1 commit into from
Feb 2, 2017

Conversation

herbdool
Copy link
Contributor

@herbdool herbdool commented Nov 7, 2016

Addresses Issue #15

@herbdool
Copy link
Contributor Author

herbdool commented Nov 7, 2016

@jackaponte @palantejon I've got this ready to test. This provides basic ability to have a layout specific to CiviCRM and choose whether to apply it to either admin/public or both types of CiviCRM pages.

@herbdool herbdool changed the title Issue 15: Add a default layout for CiviCRM admin and ability to configure/set to default Add a default layout for CiviCRM admin and ability to configure/set to default. Issue #15 Nov 7, 2016
@colemanw
Copy link
Member

colemanw commented Jan 9, 2017

@jackaponte have you had a chance to try this out?

@jackaponte
Copy link

@herbdool @colemanw Apologies for taking so long to test this! Happy to report that it works very well for me; after downloading the version of civicrmtheme in commit 47b2c96 then disabling and re-enabling the module, I was able to create a new CiviCRM admin layout with no problems. That's a great improvement; many thanks, @herbdool!

Is the ultimate goal to ship a default layout that can be enabled via the civicrmtheme module?

@colemanw colemanw merged commit 5e43fd6 into civicrm:1.x-master Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants