Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHPUnit Test class declarations to use namespaced format for p… #108

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Update PHPUnit Test class declarations to use namespaced format for p… #108

merged 1 commit into from
Dec 17, 2019

Conversation

seamuslee001
Copy link
Contributor

…hpunit6 compatability

This will still work for phpunit5 but will also work for phpunit6

ping @totten @herbdool

@civibot
Copy link

civibot bot commented Dec 16, 2019

(Standard links)

@civibot civibot bot added the 1.x-master label Dec 16, 2019
@seamuslee001
Copy link
Contributor Author

ping @eileenmcnaughton also

@totten
Copy link
Member

totten commented Dec 17, 2019

Good idea @seamuslee001 . Passes r-test, which makes it valid by definition.

@totten totten merged commit 319b4ee into civicrm:1.x-master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.x-master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @totten