[Bug]: Cargo-Payment-Rates-Graph has vanilla values

[mariocvj]

Version of OpenTTD

Citymania-client-14.1-windows-win64

Expected result

I attached the screenshot of the graph from Citymania v13.4 which does not have this bug, notice the Goods and Valuables dropoff is at 80 days.

Actual result

Lines drawn on the graph are same as official OpenTTD version despite the numbers on days-in-transit axis being doubled.
I attached the screenshot of the Citymania v14.1, notice the Goods and Valuables dropoff is at 160 days.

Steps to reproduce

The bug occurs to me consistently every time I play on v14.1 of Citymania client.
Besides vanilla OpenTTD, I also tested using FIRS and the bug is still there with moded resources.

[ladysadie]

Even in the 13.4 version code this graph is actually pretty misleading. It is telling the user it's displaying values from 20 ticks up to 480 ticks.

The data it's actually calculating is way different. It starts at 8 ticks and goes to 192 ticks.

[ladysadie]

Fixing the calculations isn't a hard fix. It kind of breaks the graph though:

I suspect that means the assumption of 10 units x 20 blocks is just not big enough to generate useful graph data. Increasing that should help? I'm just not sure what values the graph should use. I'll try a few though.

[ladysadie]

Okay changing the amount of cargo or the distance didn't change the data. It just scaled the Y axis labels accordingly.

[ladysadie]

Dropping the number of steps makes the differences easier to see:

[ldpl]

Even in the 13.4 version code this graph is actually pretty misleading. It is telling the user it's displaying values from 20 ticks up to 480 ticks.
The data it's actually calculating is way different. It starts at 8 ticks and goes to 192 ticks.

X axis on the chart is in days and afaict it calculates them correctly. You were probably confused by GetTransportedGoodsIncome taking transfer periods which are 2.5 days each.