Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#90): Inject environment variables as test variables before scenario #91

Merged
merged 1 commit into from
Apr 25, 2020
Merged

fix(#90): Inject environment variables as test variables before scenario #91

merged 1 commit into from
Apr 25, 2020

Conversation

christophd
Copy link
Member

@christophd christophd commented Apr 24, 2020 •
edited
Loading

Fixes #90

@christophd christophd force-pushed the issue/90/inject-env-vars branch from 7cbed0b to 42de01c Compare April 24, 2020 13:55
nicolaferraro
nicolaferraro reviewed Apr 24, 2020
View reviewed changes
Copy link
Collaborator

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss the part where the namespace info is forwarded to the test pod (e.g. via downward api)... How does it work?

@christophd
Copy link
Member Author

You can pass any env via CLI option

yaks test some-test --env YAKS_NAMESPACE=foo

These get set on the test CRD. I think we can auto add the env setting with the current namespace the test is working on.

@christophd
fix(citrusframework#90): Inject environment variables as test variabl…
02dd5e3 
…es before scenario

By default add YAKS_NAMESPACE environment variable to CRD so it gets injected to the test runtime as test variable
@christophd christophd force-pushed the issue/90/inject-env-vars branch from 42de01c to 02dd5e3 Compare April 24, 2020 18:23
@christophd
Copy link
Member Author

I have added the YAKS_NAMESPACE variable by default so it gets injected to all test runtimes

@christophd christophd merged commit ada111b into citrusframework:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro left review comments

@bouskaJ bouskaJ bouskaJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for environment variable in feature file
3 participants
@christophd @nicolaferraro @bouskaJ