Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yaks CLI fixes #86

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Yaks CLI fixes #86

merged 3 commits into from
Apr 22, 2020

Conversation

nicolaferraro
Copy link
Collaborator

This contains some improvements for the CLI:

  • support for multiline scripts in run
  • injection of the YAKS_NAMESPACE environment variable
  • using a consistent base dir for the script

christophd
christophd approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! That's what I wanted to do in the first place. Many thanks!

@christophd
Copy link
Member

@nicolaferraro You see I am still a Java developer with all the ; ending the lines 😄

@christophd christophd merged commit 716e14a into citrusframework:master Apr 22, 2020
@nicolaferraro
Copy link
Collaborator Author

@nicolaferraro You see I am still a Java developer with all the ; ending the lines

Ehehe.. I use to format the file using gofmt ... that's why they disappeared ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@christophd christophd christophd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolaferraro @christophd @oscerd