Env var support #52
Merged
Env var support #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophd
reviewed
Mar 6, 2020
There was a problem hiding this comment.
Cool idea!
I suggest that we use a common env var name prefix like YAKS_ so all YAKS runtime related env vars share the same prefix. We should also use a common prefix per test step module. So for yaks-testing-camel-k it would be something like YAKS_CAMELK_.
This way we can separate env var settings over various test step modules and make sure not to collide with others.
oscerd
approved these changes
Mar 6, 2020
|
Agree. I will go with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.