Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camel-K integration is running step is bound only to the pod phase not to the pod conditions #120

Closed
bouskaJ opened this issue Jul 23, 2020 · 0 comments
Closed

Camel-K integration is running step is bound only to the pod phase not to the pod conditions #120

bouskaJ opened this issue Jul 23, 2020 · 0 comments
Assignees
@bouskaJ
Labels
enhancement New feature or request

Comments

@bouskaJ
Copy link
Collaborator

bouskaJ commented Jul 23, 2020

Camel-K integration is running step is bound only to the pod phase. The pod phase does not reflect container statuses. Let's see snipped from the documentation: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/

phase: running: The Pod has been bound to a node, and all of the Containers have been created. At least one Container is still running, or is in the process of starting or restarting.

This means that if our pod has more containers (knative sidecars or so) Camel-K probes are completely ignored by YAKS (at least one container is running - the sidecar -> the pod is ready)

We should monitor also pod conditions that bring finer granularity.
@bouskaJ bouskaJ added the enhancement New feature or request label Jul 23, 2020
@bouskaJ bouskaJ self-assigned this Jul 23, 2020
bouskaJ added a commit to bouskaJ/yaks that referenced this issue Jul 24, 2020
@bouskaJ
fix(citrusframework#120): Check container statuses on integration pods
610f301
christophd added a commit that referenced this issue Jul 24, 2020
@christophd
Merge pull request #121 from bouskaJ/issue_120
88ec0d7 
fix(#120): Check container statuses on integration pods
@bouskaJ bouskaJ closed this as completed Jul 24, 2020
bouskaJ added a commit to bouskaJ/camel-k-example-event-streaming that referenced this issue Sep 3, 2020
@bouskaJ
Remove workaround for Knative services
b6ee71d 
citrusframework/yaks#120 is fixed
@bouskaJ bouskaJ mentioned this issue Sep 3, 2020
Merged
orpiske pushed a commit to openshift-integration/camel-k-example-event-streaming that referenced this issue Sep 3, 2020
@bouskaJ @orpiske
Remove workaround for Knative services
374d90c 
citrusframework/yaks#120 is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bouskaJ bouskaJ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bouskaJ