refactor: replace in(s)/out(s) with input(s)/output(s) #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also prints a deprecation warning for users to switch to the consistent syntax. # Conflicts: # blockscipy/src/scripts/equiv_address/equiv_address_proxy_py.cpp
maltemoeser
force-pushed
the
refactor/in-out-api-change-patched
branch
from
fc4a130 to
74d8a72
Compare
|
Rebased (#387 is now in v0.6) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
in(s)/out(s)toinput(s)/output(s)to avoid confusion withincoming andoutgoing funds (i.e., outputs correspond to incoming funds, inputs to outgoing funds).Also prints a deprecation warning for users to switch to the consistent syntax.