fix: flawed multisig handling caused by non-deterministic (compressed) pubkeys #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompressed pubkeys
mplattner
changed the title
maltemoeser
pushed a commit
that referenced
this pull request
Jan 31, 2020
…ompressed pubkeys BREAKING CHANGE: Reparsing the blockchain is strongly recommended. In v0.6 the format of raw pubkeys was changed from a dedicated class (CPubKey) to an array (std::array<unsigned char, 65>). The dedicated class handled compressed pubkeys with 33 bytes correctly, while the new array left the remaining bytes uninitialized. This caused non-deterministic parser outputs and incorrect handling of multisig addresses. Closes #367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v0.6 the format of raw pubkeys was changed from a dedicated class (
CPubKey) to an array (std::array<unsigned char, 65>). The class handled compressed pubkeys with 33 bytes correctly, while the new array leaves the remaining bytes uninitialized. This causes non-deterministic parser outputs and errors in the handling of multisig addresses. This PR fixes this issue.