Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6603 Add bibliography to BlueBook Law Review #6634

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

trackleft
Copy link
Contributor

This allows us to use this style with https://github.com/seboettg/citeproc-php

@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

bluebook-law-review: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[25, "25:0: ERROR: Did not expect element locale there"], [25, "25:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

Please check the test report for details.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bluebook-law-review.csl (modified style)
Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, (Bob Hancké, Martin Rhodes, & Mark Thatcher eds., 2007); CSL search by example, Citation Style Editor (2012), http://editor.citationstyles.org/searchByExample/ (last visited Dec 15, 2012).
Isabela Mares, Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?, in Varieties of capitalism. The institutional foundations of comparative advantage 184 (Peter A. Hall & David Soskice eds., 2001); Martin Fenner et al., A Data Citation Roadmap for Scholarly Data Repositories, 6 Sci. Data 28 (2019), http://www.nature.com/articles/s41597-019-0031-8 (last visited Apr 27, 2019).

Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, (Bob Hancké, Martin Rhodes, & Mark Thatcher eds., 2007).
CSL search by example, Citation Style Editor (2012), http://editor.citationstyles.org/searchByExample/ (last visited Dec 15, 2012).
Isabela Mares, Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?, in Varieties of capitalism. The institutional foundations of comparative advantage 184 (Peter A. Hall & David Soskice eds., 2001).
Martin Fenner et al., A Data Citation Roadmap for Scholarly Data Repositories, 6 Sci. Data 28 (2019), http://www.nature.com/articles/s41597-019-0031-8 (last visited Apr 27, 2019).
 <span style="font-variant: small-caps">Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</span>, (Bob Hancké, Martin Rhodes, &amp; Mark Thatcher eds., 2007); CSL search by example, <span style="font-variant: small-caps">Citation Style Editor</span> (2012), http://editor.citationstyles.org/searchByExample/ (last visited Dec 15, 2012).<br/>
 Isabela Mares, <i>Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?</i>, <i>in</i> <span style="font-variant: small-caps">Varieties of capitalism. The institutional foundations of comparative advantage</span> 184 (Peter A. Hall &amp; David Soskice eds., 2001); Martin Fenner et al., <i>A Data Citation Roadmap for Scholarly Data Repositories</i>, 6 <span style="font-variant: small-caps">Sci. Data</span> 28 (2019), http://www.nature.com/articles/s41597-019-0031-8 (last visited Apr 27, 2019).<br/>
+<hr/>
+<span style="font-variant: small-caps">Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</span>, (Bob Hancké, Martin Rhodes, &amp; Mark Thatcher eds., 2007).<br/>
+CSL search by example, <span style="font-variant: small-caps">Citation Style Editor</span> (2012), http://editor.citationstyles.org/searchByExample/ (last visited Dec 15, 2012).<br/>
+Isabela Mares, <i>Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?</i>, <i>in</i> <span style="font-variant: small-caps">Varieties of capitalism. The institutional foundations of comparative advantage</span> 184 (Peter A. Hall &amp; David Soskice eds., 2001).<br/>
+Martin Fenner et al., <i>A Data Citation Roadmap for Scholarly Data Repositories</i>, 6 <span style="font-variant: small-caps">Sci. Data</span> 28 (2019), http://www.nature.com/articles/s41597-019-0031-8 (last visited Apr 27, 2019).<br/>

@trackleft
Copy link
Contributor Author

trackleft commented Aug 11, 2023

LGTM - but I am no expert.

FYI, the bibliography is just a copy of the citation, but without the delimiter that exists on the layout element

https://github.com/citation-style-language/styles/pull/6634/files#diff-4692b75aa68c29728e76890678ca4c44fa5a4490d99637891a78b37aca0c2a30R247-R293

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

bluebook-law-review.csl (modified style)
Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, (Bob Hancké, Martin Rhodes, & Mark Thatcher eds., 2007); CSL search by example, Citation Style Editor (2012), http://editor.citationstyles.org/searchByExample/ (last visited Dec 15, 2012).
Isabela Mares, Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?, in Varieties of capitalism. The institutional foundations of comparative advantage 184 (Peter A. Hall & David Soskice eds., 2001); Martin Fenner et al., A Data Citation Roadmap for Scholarly Data Repositories, 6 Sci. Data 28 (2019), http://www.nature.com/articles/s41597-019-0031-8 (last visited Apr 27, 2019).

Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, (Bob Hancké, Martin Rhodes, & Mark Thatcher eds., 2007).
CSL search by example, Citation Style Editor (2012), http://editor.citationstyles.org/searchByExample/ (last visited Dec 15, 2012).
Isabela Mares, Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?, in Varieties of capitalism. The institutional foundations of comparative advantage 184 (Peter A. Hall & David Soskice eds., 2001).
Martin Fenner et al., A Data Citation Roadmap for Scholarly Data Repositories, 6 Sci. Data 28 (2019), http://www.nature.com/articles/s41597-019-0031-8 (last visited Apr 27, 2019).
 <span style="font-variant: small-caps">Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</span>, (Bob Hancké, Martin Rhodes, &amp; Mark Thatcher eds., 2007); CSL search by example, <span style="font-variant: small-caps">Citation Style Editor</span> (2012), http://editor.citationstyles.org/searchByExample/ (last visited Dec 15, 2012).<br/>
 Isabela Mares, <i>Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?</i>, <i>in</i> <span style="font-variant: small-caps">Varieties of capitalism. The institutional foundations of comparative advantage</span> 184 (Peter A. Hall &amp; David Soskice eds., 2001); Martin Fenner et al., <i>A Data Citation Roadmap for Scholarly Data Repositories</i>, 6 <span style="font-variant: small-caps">Sci. Data</span> 28 (2019), http://www.nature.com/articles/s41597-019-0031-8 (last visited Apr 27, 2019).<br/>
+<hr/>
+<span style="font-variant: small-caps">Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</span>, (Bob Hancké, Martin Rhodes, &amp; Mark Thatcher eds., 2007).<br/>
+CSL search by example, <span style="font-variant: small-caps">Citation Style Editor</span> (2012), http://editor.citationstyles.org/searchByExample/ (last visited Dec 15, 2012).<br/>
+Isabela Mares, <i>Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?</i>, <i>in</i> <span style="font-variant: small-caps">Varieties of capitalism. The institutional foundations of comparative advantage</span> 184 (Peter A. Hall &amp; David Soskice eds., 2001).<br/>
+Martin Fenner et al., <i>A Data Citation Roadmap for Scholarly Data Repositories</i>, 6 <span style="font-variant: small-caps">Sci. Data</span> 28 (2019), http://www.nature.com/articles/s41597-019-0031-8 (last visited Apr 27, 2019).<br/>

@bwiernik
Copy link
Member

bwiernik commented Sep 2, 2023

Can you explain how the current version without a bibliography doesn't work with citeproc-php?

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Sep 2, 2023
@trackleft
Copy link
Contributor Author

Without the bibliography I see this error

Error: Call to a member function render() on null in Seboettg\CiteProc\CiteProc->bibliography() (line 137 of /code/vendor/seboettg/citeproc-php/src/CiteProc.php).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants