Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create optics-letters.csl #4661

Merged
merged 11 commits into from
Apr 2, 2020
Merged

Conversation

POBrien333
Copy link
Contributor

@POBrien333 POBrien333 commented Apr 1, 2020

via https://forums.zotero.org/discussion/82127/style-request-optics-letters#latest

Optics Letters uses a shorter version of the the-opitical-society.csl style.

@csl-bot
Copy link

csl-bot commented Apr 1, 2020

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link

csl-bot commented Apr 1, 2020

😟 There are some issues with your submission.

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Apr 1, 2020

😟 There are some issues with your submission.

2 tests failed

optics-letters: must be an independent style (dependent styles must be placed in the "dependent" subdirectory)

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" default-locale="en-US" children=[1]>.independent?` to return true, got false

optics-letters: must have a "class" attribute that matches the "citation-format" attribute

expected: "in-text"
     got: nil

(compared using ==)

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Apr 1, 2020

😟 There are some issues with your submission.

4 tests failed

optics-letters: must be an independent style (dependent styles must be placed in the "dependent" subdirectory)

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" default-locale="en-US" children=[1]>.independent?` to return true, got false

optics-letters: must have a "class" attribute that matches the "citation-format" attribute

expected: "in-text"
     got: nil

(compared using ==)

dependent/advances-in-optics-and photonics: must have a conventional file name

expected "advances-in-optics-and photonics.csl" to match /^[a-z\d]+(-[a-z\d]+)*\.csl$/
Diff:
@@ -1,2 +1,2 @@
-/^[a-z\d]+(-[a-z\d]+)*\.csl$/
+"advances-in-optics-and photonics.csl"

dependent/advances-in-optics-and photonics: must have the same citation-format as its independent-parent

expected: :numeric
     got: :"author-date"

(compared using ==)

Diff:
@@ -1,2 +1,2 @@
-:numeric
+:"author-date"

Please check the test report for details.

@POBrien333 POBrien333 changed the title Create optics-letters.csl WIP: Create optics-letters.csl Apr 1, 2020
@csl-bot
Copy link

csl-bot commented Apr 1, 2020

😟 There are some issues with your submission.

3 tests failed

optics-letters: must be an independent style (dependent styles must be placed in the "dependent" subdirectory)

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="in-text" default-locale="en-US" children=[1]>.independent?` to return true, got false

dependent/advances-in-optics-and photonics: must have a conventional file name

expected "advances-in-optics-and photonics.csl" to match /^[a-z\d]+(-[a-z\d]+)*\.csl$/
Diff:
@@ -1,2 +1,2 @@
-/^[a-z\d]+(-[a-z\d]+)*\.csl$/
+"advances-in-optics-and photonics.csl"

dependent/advances-in-optics-and photonics: must have the same citation-format as its independent-parent

expected: :numeric
     got: :"author-date"

(compared using ==)

Diff:
@@ -1,2 +1,2 @@
-:numeric
+:"author-date"

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Apr 1, 2020

😟 There are some issues with your submission.

2 tests failed

dependent/advances-in-optics-and photonics: must have a conventional file name

expected "advances-in-optics-and photonics.csl" to match /^[a-z\d]+(-[a-z\d]+)*\.csl$/
Diff:
@@ -1,2 +1,2 @@
-/^[a-z\d]+(-[a-z\d]+)*\.csl$/
+"advances-in-optics-and photonics.csl"

dependent/advances-in-optics-and photonics: must have the same citation-format as its independent-parent

expected: :numeric
     got: :"author-date"

(compared using ==)

Diff:
@@ -1,2 +1,2 @@
-:numeric
+:"author-date"

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Apr 1, 2020

😟 There are some issues with your submission.

2 tests failed

dependent/advances-in-optics-and photonics: must have a conventional file name

expected "advances-in-optics-and photonics.csl" to match /^[a-z\d]+(-[a-z\d]+)*\.csl$/
Diff:
@@ -1,2 +1,2 @@
-/^[a-z\d]+(-[a-z\d]+)*\.csl$/
+"advances-in-optics-and photonics.csl"

dependent/advances-in-optics-and photonics: must have the same citation-format as its independent-parent

expected: :numeric
     got: :"author-date"

(compared using ==)

Diff:
@@ -1,2 +1,2 @@
-:numeric
+:"author-date"

Please check the test report for details.

@POBrien333 POBrien333 changed the title WIP: Create optics-letters.csl Create optics-letters.csl Apr 1, 2020
@csl-bot
Copy link

csl-bot commented Apr 1, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

optics-letters.csl (new)
[1,2]
[3,4]

1. B. Hancké, M. Rhodes, and M. Thatcher, eds., (Oxford University Press, 2007).
2. Citation Style Editor (2012).
3. I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, P. A. Hall and D. Soskice, eds. (Oxford University Press, 2001), pp. 184–213.
4. M. Fenner, M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data 6, 28 (2019).
dependent/advances-in-optics-and-photonics.csl (rendering failure)

@csl-bot
Copy link

csl-bot commented Apr 1, 2020

😟 There are some issues with your submission.

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Apr 1, 2020

😟 There are some issues with your submission.

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Apr 1, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

optics-letters.csl (new)
[1,2]
[3,4]

1. B. Hancké, M. Rhodes, and M. Thatcher, eds., (Oxford University Press, 2007).
2. Citation Style Editor (2012).
3. I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, P. A. Hall and D. Soskice, eds. (Oxford University Press, 2001), pp. 184–213.
4. M. Fenner, M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data 6, 28 (2019).

@csl-bot
Copy link

csl-bot commented Apr 2, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

optics-letters.csl (new)
[1,2]
[3,4]

1. B. Hancké, M. Rhodes, and M. Thatcher, eds., (Oxford University Press, 2007).
2. Citation Style Editor (2012).
3. I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, P. A. Hall and D. Soskice, eds. (Oxford University Press, 2001), pp. 184–213.
4. M. Fenner, M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data 6, 28 (2019).

@rmzelle rmzelle merged commit 3ba11bc into citation-style-language:master Apr 2, 2020
@rmzelle
Copy link
Member

rmzelle commented Apr 2, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants