Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update freshwater-science.csl #4658

Merged
merged 5 commits into from
Apr 2, 2020

Conversation

POBrien333
Copy link
Contributor

@POBrien333 POBrien333 commented Mar 31, 2020

@csl-bot
Copy link

csl-bot commented Mar 31, 2020

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link

csl-bot commented Mar 31, 2020

😟 There are some issues with your submission.

2 tests failed

freshwater-science: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[23, "23:0: ERROR: Did not expect element locale there"], [23, "23:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to return true, got false

freshwater-science: must not use sentence case for title and container-title variables

expected "title" not to match /^title|container-title$/
Diff:
@@ -1,2 +1,2 @@
-/^title|container-title$/
+"title"

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Mar 31, 2020

😟 There are some issues with your submission.

1 test failed

freshwater-science: must not use sentence case for title and container-title variables

expected "title" not to match /^title|container-title$/
Diff:
@@ -1,2 +1,2 @@
-/^title|container-title$/
+"title"

Please check the test report for details.

@POBrien333
Copy link
Contributor Author

Can you guys help me here?
Book titles should be rendered with a capital for the first letter of a subtitle. I added the text-case="sentence" for this, but it seems I can't do this?
Any help would be appreciated :)

@csl-bot
Copy link

csl-bot commented Mar 31, 2020

😟 There are some issues with your submission.

1 test failed

freshwater-science: must not use sentence case for title and container-title variables

expected "title" not to match /^title|container-title$/
Diff:
@@ -1,2 +1,2 @@
-/^title|container-title$/
+"title"

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Mar 31, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

freshwater-science.csl (modified style)
(Hancké et al. 2007, “CSL search by example” 2012)
(Mares 2001, Fenner et al. 2019)

CSL search by example. 2012. Citation Style Editor. (Available from: http://editor.citationstyles.org/searchByExample/)
Fenner, M., M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6:28.
Hancké, B., M. Rhodes, and M. Thatcher (Eds.). 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University PressOxford and New York.
Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? Pages 184–213 in P. A. Hall and D. Soskice (editors). Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University PressNew York.
 (Hancké et al. 2007, “CSL search by example” 2012)<br/>
 (Mares 2001, Fenner et al. 2019)<br/>
 <hr/>
-<span style="font-variant: small-caps">CSL search by example</span>. 2012. . http://editor.citationstyles.org/searchByExample/.<br/>
-<span style="font-variant: small-caps">Fenner, M., M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark</span>. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6:28.<br/>
-<span style="font-variant: small-caps">Hancké, B., M. Rhodes, and M. Thatcher (Eds.)</span>. 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University PressOxford and New York.<br/>
-<span style="font-variant: small-caps">Mares, I.</span> 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? Pages 184–213 <i>in</i> P. A. Hall and D. Soskice (editors). Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University PressNew York.<br/>
+<span style="font-variant: normal">CSL search by example</span>. 2012. Citation Style Editor. (Available from: http://editor.citationstyles.org/searchByExample/)<br/>
+<span style="font-variant: normal">Fenner, M., M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark</span>. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6:28.<br/>
+<span style="font-variant: normal">Hancké, B., M. Rhodes, and M. Thatcher (Eds.)</span>. 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University PressOxford and New York.<br/>
+<span style="font-variant: normal">Mares, I.</span> 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? Pages 184–213 <i>in</i> P. A. Hall and D. Soskice (editors). Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University PressNew York.<br/>

@csl-bot
Copy link

csl-bot commented Mar 31, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

freshwater-science.csl (modified style)
(Hancké et al. 2007, “CSL search by example” 2012)
(Mares 2001, Fenner et al. 2019)

CSL search by example. 2012. Citation Style Editor. (Available from: http://editor.citationstyles.org/searchByExample/)
Fenner, M., M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6:28.
Hancké, B., M. Rhodes, and M. Thatcher (Eds.). 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University PressOxford and New York.
Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? Pages 184–213 in P. A. Hall and D. Soskice (editors). Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University PressNew York.
 (Hancké et al. 2007, “CSL search by example” 2012)<br/>
 (Mares 2001, Fenner et al. 2019)<br/>
 <hr/>
-<span style="font-variant: small-caps">CSL search by example</span>. 2012. . http://editor.citationstyles.org/searchByExample/.<br/>
-<span style="font-variant: small-caps">Fenner, M., M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark</span>. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6:28.<br/>
-<span style="font-variant: small-caps">Hancké, B., M. Rhodes, and M. Thatcher (Eds.)</span>. 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University PressOxford and New York.<br/>
-<span style="font-variant: small-caps">Mares, I.</span> 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? Pages 184–213 <i>in</i> P. A. Hall and D. Soskice (editors). Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University PressNew York.<br/>
+<span style="font-variant: normal">CSL search by example</span>. 2012. Citation Style Editor. (Available from: http://editor.citationstyles.org/searchByExample/)<br/>
+<span style="font-variant: normal">Fenner, M., M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark</span>. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6:28.<br/>
+<span style="font-variant: normal">Hancké, B., M. Rhodes, and M. Thatcher (Eds.)</span>. 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University PressOxford and New York.<br/>
+<span style="font-variant: normal">Mares, I.</span> 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? Pages 184–213 <i>in</i> P. A. Hall and D. Soskice (editors). Varieties of capitalism. The institutional foundations of comparative advantage. Oxford University PressNew York.<br/>

@rmzelle rmzelle merged commit 0dc2e37 into citation-style-language:master Apr 2, 2020
@rmzelle
Copy link
Member

rmzelle commented Apr 2, 2020

Can you guys help me here?
Book titles should be rendered with a capital for the first letter of a subtitle. I added the text-case="sentence" for this, but it seems I can't do this?

Pretty sure CSL 1.0.1 doesn't have a concept of subtitles, so I don't think you can do anything in the style itself to address this. (although citeproc-js might have implemented some heuristics to automatically reformat subtitles; not sure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants