-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl #4460
Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl #4460
Conversation
Atualização do estilo associacao-brasileira-de-normas-tecnicas-ufrgs.csl conforme a nova norma ABNT 6023:2018.
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😟 There are some issues with your submission. Please check the test report for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions & some requested changes. Please apply equally to your other PR
@@ -71,7 +85,7 @@ | |||
<name-part name="family" text-case="uppercase"/> | |||
<name-part name="given" text-case="capitalize-first"/> | |||
</name> | |||
<label form="short" text-case="capitalize-first" prefix=" (" suffix=".)"/> | |||
<et-al font-style="italic"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the label here seems wrong -- you'd really not mark people as editors/translators?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are using editors and translators, but didn't understand what is wrong here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're removing the label. The old version says (Org.) or (Orgs.) after their name. Yours doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
É porque a norma mudou e não muda mais o termo se single ou multiple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you're removing the label entirely. You've already changed the terms above so the label will never display in plural.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't resolve conversations that aren't actually resolved -- you still have the label removed. See the Mares example citation:
MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, Peter A.; SOSKICE, David. Varieties of capitalism. The institutional foundations of comparative advantage. Tradução . New York: Oxford University Press, 2001. p. 184–213.
Note the missing (ed.) after D. Soskice -- is that really intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realmente estava faltando. Foi corrigido. Obrigada
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Só mais uma questão. Nos meus testes não aparece este texto "Tradução" a não ser que haja um tradutor.
<else-if type="article-newspaper" match="any"> | ||
<group> | ||
<text variable="volume" prefix="ano " suffix=", "/> | ||
<text variable="edition" prefix="ano " suffix=", "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems weird and might be a misunderstanding of "edition" -- the way the term is understood in CSL, it refers to a specific version of the same work. For newspapers this might be the evening edition or a local edition of a national paper. I don't think you want to preface it with "ano"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still have edition prefaced with "ano" -- you can say if that's correct, but please don't resolve discussions unless they're actually resolved (or just let me resolve them). It makes reviewing much harder for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolvido. Obrigada. E desculpa por ter resolvido a conversa, estava na dúvida de como você saberia que tinha respondido.
<group delimiter=", "> | ||
<group delimiter=", "> | ||
<text variable="volume" prefix="v. "/> | ||
<text variable="edition" prefix="v. "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as below about "edition"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolvido. Obrigada.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
😃 Your submission passed all our automated tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All possible changes were made.
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: associacao-brasileira-de-normas-tecnicas-ufrgs.csl (modified style)(CSL SEARCH BY EXAMPLE, 2012; HANCKÉ; RHODES; THATCHER, 2007) (CSL SEARCH BY EXAMPLE, 2012; HANCKÉ; RHODES; THATCHER, 2007)<br/>
-(FENNER et al., 2019; MARES, 2001)<br/>
+(FENNER <i>et al.</i>, 2019; MARES, 2001)<br/>
<hr/>
-<b>CSL search by example</b>. 2012. Disponível em: <http://editor.citationstyles.org/searchByExample/>. Acesso em: 15 dez. 2012. <br/>
-FENNER, Martin et al. A data citation roadmap for scholarly data repositories. <b>Scientific Data</b>, [s. l.], v. 6, n. 1, p. 28, 2019. Disponível em: <http://www.nature.com/articles/s41597-019-0031-8>. Acesso em: 27 abr. 2019.<br/>
-HANCKÉ, Bob; RHODES, Martin; THATCHER, Mark (EDS.). <b>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</b>. Traducao . Oxford and New York: Oxford University Press, 2007. <br/>
-MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, Peter A.; SOSKICE, David (Eds.). <b>Varieties of capitalism. The institutional foundations of comparative advantage</b>. Traducao . New York: Oxford University Press, 2001. p. 184–213. <br/>
+<b>CSL search by example</b>. . <b>Citation Style Editor</b>, 2012. Disponível em: http://editor.citationstyles.org/searchByExample/. Acesso em: 15 dez. 2012.<br/>
+FENNER, Martin <i>et al.</i> <span style="font-weight: normal">A data citation roadmap for scholarly data repositories</span>. <b>Scientific Data</b>, <i>[S. l.]</i>, v. 6, n. 1, p. 28, 2019. Disponível em: http://www.nature.com/articles/s41597-019-0031-8. Acesso em: 27 abr. 2019.<br/>
+HANCKÉ, Bob; RHODES, Martin; THATCHER, Mark (ed.). <b>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</b>. Tradução . Oxford and New York: Oxford University Press, 2007. <i>E-book</i>.<br/>
+MARES, Isabela. <span style="font-weight: normal">Firms and the welfare state: When, why, and how does social policy matter to employers?</span> <i>In</i>: HALL, Peter A.; SOSKICE, David. <b>Varieties of capitalism. The institutional foundations of comparative advantage</b>. Tradução . New York: Oxford University Press, 2001. p. 184–213. <i>E-book</i>.<br/>
|
1 similar comment
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: associacao-brasileira-de-normas-tecnicas-ufrgs.csl (modified style)(CSL SEARCH BY EXAMPLE, 2012; HANCKÉ; RHODES; THATCHER, 2007) (CSL SEARCH BY EXAMPLE, 2012; HANCKÉ; RHODES; THATCHER, 2007)<br/>
-(FENNER et al., 2019; MARES, 2001)<br/>
+(FENNER <i>et al.</i>, 2019; MARES, 2001)<br/>
<hr/>
-<b>CSL search by example</b>. 2012. Disponível em: <http://editor.citationstyles.org/searchByExample/>. Acesso em: 15 dez. 2012. <br/>
-FENNER, Martin et al. A data citation roadmap for scholarly data repositories. <b>Scientific Data</b>, [s. l.], v. 6, n. 1, p. 28, 2019. Disponível em: <http://www.nature.com/articles/s41597-019-0031-8>. Acesso em: 27 abr. 2019.<br/>
-HANCKÉ, Bob; RHODES, Martin; THATCHER, Mark (EDS.). <b>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</b>. Traducao . Oxford and New York: Oxford University Press, 2007. <br/>
-MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, Peter A.; SOSKICE, David (Eds.). <b>Varieties of capitalism. The institutional foundations of comparative advantage</b>. Traducao . New York: Oxford University Press, 2001. p. 184–213. <br/>
+<b>CSL search by example</b>. . <b>Citation Style Editor</b>, 2012. Disponível em: http://editor.citationstyles.org/searchByExample/. Acesso em: 15 dez. 2012.<br/>
+FENNER, Martin <i>et al.</i> <span style="font-weight: normal">A data citation roadmap for scholarly data repositories</span>. <b>Scientific Data</b>, <i>[S. l.]</i>, v. 6, n. 1, p. 28, 2019. Disponível em: http://www.nature.com/articles/s41597-019-0031-8. Acesso em: 27 abr. 2019.<br/>
+HANCKÉ, Bob; RHODES, Martin; THATCHER, Mark (ed.). <b>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</b>. Tradução . Oxford and New York: Oxford University Press, 2007. <i>E-book</i>.<br/>
+MARES, Isabela. <span style="font-weight: normal">Firms and the welfare state: When, why, and how does social policy matter to employers?</span> <i>In</i>: HALL, Peter A.; SOSKICE, David. <b>Varieties of capitalism. The institutional foundations of comparative advantage</b>. Tradução . New York: Oxford University Press, 2001. p. 184–213. <i>E-book</i>.<br/>
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: associacao-brasileira-de-normas-tecnicas-ufrgs.csl (modified style)(CSL SEARCH BY EXAMPLE, 2012; HANCKÉ; RHODES; THATCHER, 2007) (CSL SEARCH BY EXAMPLE, 2012; HANCKÉ; RHODES; THATCHER, 2007)<br/>
-(FENNER et al., 2019; MARES, 2001)<br/>
+(FENNER <i>et al.</i>, 2019; MARES, 2001)<br/>
<hr/>
-<b>CSL search by example</b>. 2012. Disponível em: <http://editor.citationstyles.org/searchByExample/>. Acesso em: 15 dez. 2012. <br/>
-FENNER, Martin et al. A data citation roadmap for scholarly data repositories. <b>Scientific Data</b>, [s. l.], v. 6, n. 1, p. 28, 2019. Disponível em: <http://www.nature.com/articles/s41597-019-0031-8>. Acesso em: 27 abr. 2019.<br/>
-HANCKÉ, Bob; RHODES, Martin; THATCHER, Mark (EDS.). <b>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</b>. Traducao . Oxford and New York: Oxford University Press, 2007. <br/>
-MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, Peter A.; SOSKICE, David (Eds.). <b>Varieties of capitalism. The institutional foundations of comparative advantage</b>. Traducao . New York: Oxford University Press, 2001. p. 184–213. <br/>
+<b>CSL search by example</b>. . <b>Citation Style Editor</b>, 2012. Disponível em: http://editor.citationstyles.org/searchByExample/. Acesso em: 15 dez. 2012.<br/>
+FENNER, Martin <i>et al.</i> <span style="font-weight: normal">A data citation roadmap for scholarly data repositories</span>. <b>Scientific Data</b>, <i>[S. l.]</i>, v. 6, n. 1, p. 28, 2019. Disponível em: http://www.nature.com/articles/s41597-019-0031-8. Acesso em: 27 abr. 2019.<br/>
+HANCKÉ, Bob; RHODES, Martin; THATCHER, Mark (ed.). <b>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</b>. Tradução . Oxford and New York: Oxford University Press, 2007. <i>E-book</i>.<br/>
+MARES, Isabela. <span style="font-weight: normal">Firms and the welfare state: When, why, and how does social policy matter to employers?</span> <i>In</i>: HALL, Peter A.; SOSKICE, David. <b>Varieties of capitalism. The institutional foundations of comparative advantage</b>. Tradução . New York: Oxford University Press, 2001. p. 184–213. <i>E-book</i>.<br/>
|
@adam3smith, feel free to merge. (and #4461 as well) |
😃 Your submission passed all our automated tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of unresolved issues still -- please address those (also in your other PR). Also, I removed the name-parts that didn't affect the code. Please check that things are till working as desired on your end.
@@ -71,7 +85,7 @@ | |||
<name-part name="family" text-case="uppercase"/> | |||
<name-part name="given" text-case="capitalize-first"/> | |||
</name> | |||
<label form="short" text-case="capitalize-first" prefix=" (" suffix=".)"/> | |||
<et-al font-style="italic"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't resolve conversations that aren't actually resolved -- you still have the label removed. See the Mares example citation:
MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, Peter A.; SOSKICE, David. Varieties of capitalism. The institutional foundations of comparative advantage. Tradução . New York: Oxford University Press, 2001. p. 184–213.
Note the missing (ed.) after D. Soskice -- is that really intentional?
<else-if type="article-newspaper" match="any"> | ||
<group> | ||
<text variable="volume" prefix="ano " suffix=", "/> | ||
<text variable="edition" prefix="ano " suffix=", "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still have edition prefaced with "ano" -- you can say if that's correct, but please don't resolve discussions unless they're actually resolved (or just let me resolve them). It makes reviewing much harder for me.
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: associacao-brasileira-de-normas-tecnicas-ufrgs.csl (modified style)(CSL SEARCH BY EXAMPLE, 2012; HANCKÉ; RHODES; THATCHER, 2007) (CSL SEARCH BY EXAMPLE, 2012; HANCKÉ; RHODES; THATCHER, 2007)<br/>
-(FENNER et al., 2019; MARES, 2001)<br/>
+(FENNER <i>et al.</i>, 2019; MARES, 2001)<br/>
<hr/>
-<b>CSL search by example</b>. 2012. Disponível em: <http://editor.citationstyles.org/searchByExample/>. Acesso em: 15 dez. 2012. <br/>
-FENNER, Martin et al. A data citation roadmap for scholarly data repositories. <b>Scientific Data</b>, [s. l.], v. 6, n. 1, p. 28, 2019. Disponível em: <http://www.nature.com/articles/s41597-019-0031-8>. Acesso em: 27 abr. 2019.<br/>
-HANCKÉ, Bob; RHODES, Martin; THATCHER, Mark (EDS.). <b>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</b>. Traducao . Oxford and New York: Oxford University Press, 2007. <br/>
-MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, Peter A.; SOSKICE, David (Eds.). <b>Varieties of capitalism. The institutional foundations of comparative advantage</b>. Traducao . New York: Oxford University Press, 2001. p. 184–213. <br/>
+<b>CSL search by example</b>. . <b>Citation Style Editor</b>, 2012. Disponível em: http://editor.citationstyles.org/searchByExample/. Acesso em: 15 dez. 2012.<br/>
+FENNER, Martin <i>et al.</i> <span style="font-weight: normal">A data citation roadmap for scholarly data repositories</span>. <b>Scientific Data</b>, <i>[S. l.]</i>, v. 6, n. 1, p. 28, 2019. Disponível em: http://www.nature.com/articles/s41597-019-0031-8. Acesso em: 27 abr. 2019.<br/>
+HANCKÉ, Bob; RHODES, Martin; THATCHER, Mark (org.). <b>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</b>. Tradução . Oxford and New York: Oxford University Press, 2007. <i>E-book</i>.<br/>
+MARES, Isabela. <span style="font-weight: normal">Firms and the welfare state: When, why, and how does social policy matter to employers?</span> <i>In</i>: HALL, Peter A.; SOSKICE, David (org.). <b>Varieties of capitalism. The institutional foundations of comparative advantage</b>. Tradução . New York: Oxford University Press, 2001. p. 184–213. <i>E-book</i>.<br/>
|
You accidentally reverted the changes the @rmzelle and I had made to your style, right? That wasn't on purpose? |
Provavelmente >_< Não foi de propósito. Quais foram estas mudanças? |
😃 Your submission passed all our automated tests. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: associacao-brasileira-de-normas-tecnicas-ufrgs.csl (modified style)(CSL SEARCH BY EXAMPLE, 2012; HANCKÉ; RHODES; THATCHER, 2007) (CSL SEARCH BY EXAMPLE, 2012; HANCKÉ; RHODES; THATCHER, 2007)<br/>
-(FENNER et al., 2019; MARES, 2001)<br/>
+(FENNER <i>et al.</i>, 2019; MARES, 2001)<br/>
<hr/>
-<b>CSL search by example</b>. 2012. Disponível em: <http://editor.citationstyles.org/searchByExample/>. Acesso em: 15 dez. 2012. <br/>
-FENNER, Martin et al. A data citation roadmap for scholarly data repositories. <b>Scientific Data</b>, [s. l.], v. 6, n. 1, p. 28, 2019. Disponível em: <http://www.nature.com/articles/s41597-019-0031-8>. Acesso em: 27 abr. 2019.<br/>
-HANCKÉ, Bob; RHODES, Martin; THATCHER, Mark (EDS.). <b>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</b>. Traducao . Oxford and New York: Oxford University Press, 2007. <br/>
-MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? In: HALL, Peter A.; SOSKICE, David (Eds.). <b>Varieties of capitalism. The institutional foundations of comparative advantage</b>. Traducao . New York: Oxford University Press, 2001. p. 184–213. <br/>
+<b>CSL search by example</b>. . <b>Citation Style Editor</b>, 2012. Disponível em: http://editor.citationstyles.org/searchByExample/. Acesso em: 15 dez. 2012.<br/>
+FENNER, Martin <i>et al.</i> <span style="font-weight: normal">A data citation roadmap for scholarly data repositories</span>. <b>Scientific Data</b>, <i>[S. l.]</i>, v. 6, n. 1, p. 28, 2019. Disponível em: http://www.nature.com/articles/s41597-019-0031-8. Acesso em: 27 abr. 2019.<br/>
+HANCKÉ, Bob; RHODES, Martin; THATCHER, Mark (org.). <b>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</b>. Tradução . Oxford and New York: Oxford University Press, 2007. <i>E-book</i>.<br/>
+MARES, Isabela. <span style="font-weight: normal">Firms and the welfare state: When, why, and how does social policy matter to employers?</span> <i>In</i>: HALL, Peter A.; SOSKICE, David (org.). <b>Varieties of capitalism. The institutional foundations of comparative advantage</b>. Tradução . New York: Oxford University Press, 2001. p. 184–213. <i>E-book</i>.<br/>
|
Hello. We are a little lost. |
Atualização do estilo associacao-brasileira-de-normas-tecnicas-ufrgs.csl conforme a nova norma ABNT 6023:2018.